hst-seo-support html escaped page title

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

hst-seo-support html escaped page title

Joris Meijer
Hi list,

I was wondering, is there a reason why the page title is "html" escaped in the SeoHelperComponent ?
It returns a very ugly page title in case, for instance, an umlaut is used:

<title>Re&euml;en - Kinderboerderij het hertje</title>

Can I safely change this, so I can have this page title?

<title>Reëen - Kinderboerderij het hertje</title>

thanks for any info.

Joris

Reply | Threaded
Open this post in threaded view
|

Re: hst-seo-support html escaped page title

Woonsan Ko-3
Hi Joris,

I think you found a bug.
I've just looked into the code:

// SEOHelperComponent.java: L114-116
Element title = response.createElement("title");
title.setTextContent(StringEscapeUtils.escapeHtml(mergedTitle));
response.addHeadElement(title, "hst.seo.document.title");

Because it was setting text content of DOM element, it should have set a
normal unescaped string.
I'll fix this error.

In the meantime, you can override SEOHelperComponent#contributePageTitle().
Or, I will fix this problem and release it asap, so you can wait for an
update.

Regards,

Woonsan

On 8/14/12 4:48 AM, Joris Meijer wrote:

> Hi list,
>
> I was wondering, is there a reason why the page title is "html" escaped in
> the SeoHelperComponent ?
> It returns a very ugly page title in case, for instance, an umlaut is used:
>
> <title>Re&amp;euml;en - Kinderboerderij het hertje</title>
>
> Can I safely change this, so I can have this page title?
>
> <title>Reëen - Kinderboerderij het hertje</title>
>
> thanks for any info.
>
> Joris
>
>
>
>
>
> --
> View this message in context: http://hippo.2275632.n2.nabble.com/hst-seo-support-html-escaped-page-title-tp7579038.html
> Sent from the Hippo CMS 7 mailing list archive at Nabble.com.
> _______________________________________________
> Hippo-cms7-user mailing list and forums
> http://www.onehippo.org/cms7/support/forums.html
>


--
[hidden email]     www.onehippo.com
Boston - 1 Broadway, Cambridge, MA 02142
Amsterdam - Oosteinde 11, 1017 WT Amsterdam
US +1 877 414 4776 (toll free)
Europe +31(0)20 522 4466
_______________________________________________
Hippo-cms7-user mailing list and forums
http://www.onehippo.org/cms7/support/forums.html
Reply | Threaded
Open this post in threaded view
|

RE: hst-seo-support html escaped page title

Joris Meijer

Hi Woonsan,


Now that I know that you think it’s a bug, I will override the method. Thanks for your swift response!

 

Best regards,
Joris

 

 

_______________________________________________________________________

Email_CBE.gifJoris Meijer

Consultant Online Technology | Capgemini Online

 

Capgemini "Netherlands" | Utrecht

Tel.: +31 30 68 93076 – Mob.: +31 6 5158 6350

www.capgemini.com

 

People matter, results count.

_______________________________________________________________________

Connect with Capgemini:
cid:image009.gif@01CC699A.C00EB090  cid:image010.gif@01CC699A.C00EB090  cid:image011.gif@01CC699A.C00EB090  cid:image012.gif@01CC699A.C00EB090  cid:image013.gif@01CC699A.C00EB090  cid:image014.gif@01CC699A.C00EB090

 

From: Woonsan Ko-3 [via Hippo] [mailto:[hidden email]]
Sent: dinsdag 14 augustus 2012 16:25
To: Meijer, Joris
Subject: Re: hst-seo-support html escaped page title

 

Hi Joris,

I think you found a bug.
I've just looked into the code:

// SEOHelperComponent.java: L114-116
Element title = response.createElement("title");
title.setTextContent(StringEscapeUtils.escapeHtml(mergedTitle));
response.addHeadElement(title, "hst.seo.document.title");

Because it was setting text content of DOM element, it should have set a
normal unescaped string.
I'll fix this error.

In the meantime, you can override SEOHelperComponent#contributePageTitle().
Or, I will fix this problem and release it asap, so you can wait for an
update.

Regards,

Woonsan

On 8/14/12 4:48 AM, Joris Meijer wrote:


> Hi list,
>
> I was wondering, is there a reason why the page title is "html" escaped in
> the SeoHelperComponent ?
> It returns a very ugly page title in case, for instance, an umlaut is used:
>
> <title>Re&amp;euml;en - Kinderboerderij het hertje</title>
>
> Can I safely change this, so I can have this page title?
>
> <title>Reëen - Kinderboerderij het hertje</title>
>
> thanks for any info.
>
> Joris
>
>
>
>
>
> --
> View this message in context: http://hippo.2275632.n2.nabble.com/hst-seo-support-html-escaped-page-title-tp7579038.html
> Sent from the Hippo CMS 7 mailing list archive at Nabble.com.
> _______________________________________________
> Hippo-cms7-user mailing list and forums
> http://www.onehippo.org/cms7/support/forums.html
>


--
[hidden email]     www.onehippo.com
Boston - 1 Broadway, Cambridge, MA 02142
Amsterdam - Oosteinde 11, 1017 WT Amsterdam
US +1 877 414 4776 (toll free)
Europe +31(0)20 522 4466
_______________________________________________
Hippo-cms7-user mailing list and forums
http://www.onehippo.org/cms7/support/forums.html


If you reply to this email, your message will be added to the discussion below:

http://hippo.2275632.n2.nabble.com/hst-seo-support-html-escaped-page-title-tp7579038p7579044.html

To unsubscribe from hst-seo-support html escaped page title, click here.
NAML

This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is
intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to
read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message
in error, please notify the sender immediately and delete all copies of this message.

Reply | Threaded
Open this post in threaded view
|

Re: hst-seo-support html escaped page title

Woonsan Ko-3
Hi Joris,

I've just tagged/released hst-seo-support-0.01.07 with the fix.
Probably you will be able to pull it in an hour or so (due to the forge
maven repo synchronization).

Cheers,

Woonsan

On 8/14/12 10:33 AM, Joris Meijer wrote:

> Hi Woonsan,
>
> Now that I know that you think it’s a bug, I will override the method. Thanks for your swift response!
>
> Best regards,
> Joris
>
>
> _______________________________________________________________________
> [cid:image001.gif@01CD7A3A.7A8F0EA0]Joris Meijer
> Consultant Online Technology | Capgemini Online
>
> Capgemini "Netherlands" | Utrecht
> Tel.: +31 30 68 93076 – Mob.: +31 6 5158 6350
> www.capgemini.com<http://www.capgemini.com/>
>
> People matter, results count.
> _______________________________________________________________________
> Connect with Capgemini:
> [cid:image002.gif@01CD7A3A.7A8F0EA0]<http://www.capgemini.com/insights-and-resources/blogs>  [cid:image003.gif@01CD7A3A.7A8F0EA0] <http://www.twitter.com/CapgeminiNL>   [cid:image004.gif@01CD7A3A.7A8F0EA0] <http://www.facebook.com/capgemini>   [cid:image005.gif@01CD7A3A.7A8F0EA0] <http://www.linkedin.com/company/capgemini>   [cid:image006.gif@01CD7A3A.7A8F0EA0] <http://www.slideshare.net/capgemini>   [cid:image007.gif@01CD7A3A.7A8F0EA0] <http://www.youtube.com/user/Capgemini08>
>
> From: Woonsan Ko-3 [via Hippo] [mailto:[hidden email]]
> Sent: dinsdag 14 augustus 2012 16:25
> To: Meijer, Joris
> Subject: Re: hst-seo-support html escaped page title
>
> Hi Joris,
>
> I think you found a bug.
> I've just looked into the code:
>
> // SEOHelperComponent.java: L114-116
> Element title = response.createElement("title");
> title.setTextContent(StringEscapeUtils.escapeHtml(mergedTitle));
> response.addHeadElement(title, "hst.seo.document.title");
>
> Because it was setting text content of DOM element, it should have set a
> normal unescaped string.
> I'll fix this error.
>
> In the meantime, you can override SEOHelperComponent#contributePageTitle().
> Or, I will fix this problem and release it asap, so you can wait for an
> update.
>
> Regards,
>
> Woonsan
>
> On 8/14/12 4:48 AM, Joris Meijer wrote:
>
>> Hi list,
>>
>> I was wondering, is there a reason why the page title is "html" escaped in
>> the SeoHelperComponent ?
>> It returns a very ugly page title in case, for instance, an umlaut is used:
>>
>> <title>Re&amp;euml;en - Kinderboerderij het hertje</title>
>>
>> Can I safely change this, so I can have this page title?
>>
>> <title>Reëen - Kinderboerderij het hertje</title>
>>
>> thanks for any info.
>>
>> Joris
>>
>>
>>
>>
>>
>> --
>> View this message in context: http://hippo.2275632.n2.nabble.com/hst-seo-support-html-escaped-page-title-tp7579038.html
>> Sent from the Hippo CMS 7 mailing list archive at Nabble.com.
>> _______________________________________________
>> Hippo-cms7-user mailing list and forums
>> http://www.onehippo.org/cms7/support/forums.html
>>
>
>
> --
> [hidden email]</user/SendEmail.jtp?type=node&node=7579044&i=0>     www.onehippo.com
> Boston - 1 Broadway, Cambridge, MA 02142
> Amsterdam - Oosteinde 11, 1017 WT Amsterdam
> US +1 877 414 4776 (toll free)
> Europe +31(0)20 522 4466
> _______________________________________________
> Hippo-cms7-user mailing list and forums
> http://www.onehippo.org/cms7/support/forums.html
> ________________________________
> If you reply to this email, your message will be added to the discussion below:
> http://hippo.2275632.n2.nabble.com/hst-seo-support-html-escaped-page-title-tp7579038p7579044.html
> To unsubscribe from hst-seo-support html escaped page title, click here<
> NAML<
http://hippo.2275632.n2.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
>
>
>
>
>
> This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is
> intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to
> read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message
> in error, please notify the sender immediately and delete all copies of this message.
>
>
>
>
> --
> View this message in context: http://hippo.2275632.n2.nabble.com/hst-seo-support-html-escaped-page-title-tp7579038p7579045.html
> Sent from the Hippo CMS 7 mailing list archive at Nabble.com.
> _______________________________________________
> Hippo-cms7-user mailing list and forums
> http://www.onehippo.org/cms7/support/forums.html
>


--
[hidden email]     www.onehippo.com
Boston - 1 Broadway, Cambridge, MA 02142
Amsterdam - Oosteinde 11, 1017 WT Amsterdam
US +1 877 414 4776 (toll free)
Europe +31(0)20 522 4466
_______________________________________________
Hippo-cms7-user mailing list and forums
http://www.onehippo.org/cms7/support/forums.html
Reply | Threaded
Open this post in threaded view
|

RE: hst-seo-support html escaped page title

Joris Meijer

Hi Woonsan,

 

Thanks for the quick fix. I will pull it in later!

 

Best regards,

Joris

 

 

_______________________________________________________________________

Email_CBE.gifJoris Meijer

Consultant Online Technology | Capgemini Online

 

Capgemini "Netherlands" | Utrecht

Tel.: +31 30 68 93076 – Mob.: +31 6 5158 6350

www.capgemini.com

 

People matter, results count.

_______________________________________________________________________

Connect with Capgemini:
cid:image009.gif@01CC699A.C00EB090  cid:image010.gif@01CC699A.C00EB090  cid:image011.gif@01CC699A.C00EB090  cid:image012.gif@01CC699A.C00EB090  cid:image013.gif@01CC699A.C00EB090  cid:image014.gif@01CC699A.C00EB090

 

From: Woonsan Ko-3 [via Hippo] [mailto:[hidden email]]
Sent: dinsdag 14 augustus 2012 16:44
To: Meijer, Joris
Subject: Re: hst-seo-support html escaped page title

 

Hi Joris,

I've just tagged/released hst-seo-support-0.01.07 with the fix.
Probably you will be able to pull it in an hour or so (due to the forge
maven repo synchronization).

Cheers,

Woonsan

On 8/14/12 10:33 AM, Joris Meijer wrote:


> Hi Woonsan,
>
> Now that I know that you think it’s a bug, I will override the method. Thanks for your swift response!
>
> Best regards,
> Joris
>
>
> _______________________________________________________________________
> [cid:image001.gif@01CD7A3A.7A8F0EA0]Joris Meijer
> Consultant Online Technology | Capgemini Online
>
> Capgemini "Netherlands" | Utrecht
> Tel.: +31 30 68 93076 – Mob.: +31 6 5158 6350
> www.capgemini.com<http://www.capgemini.com/>
>
> People matter, results count.
> _______________________________________________________________________
> Connect with Capgemini:
> [cid:image002.gif@01CD7A3A.7A8F0EA0]<http://www.capgemini.com/insights-and-resources/blogs>  [cid:image003.gif@01CD7A3A.7A8F0EA0] <http://www.twitter.com/CapgeminiNL>   [cid:image004.gif@01CD7A3A.7A8F0EA0] <http://www.facebook.com/capgemini>   [cid:image005.gif@01CD7A3A.7A8F0EA0] <http://www.linkedin.com/company/capgemini>   [cid:image006.gif@01CD7A3A.7A8F0EA0] <http://www.slideshare.net/capgemini>   [cid:image007.gif@01CD7A3A.7A8F0EA0] <http://www.youtube.com/user/Capgemini08>
>
> From: Woonsan Ko-3 [via Hippo] [mailto:[hidden email]]
> Sent: dinsdag 14 augustus 2012 16:25
> To: Meijer, Joris
> Subject: Re: hst-seo-support html escaped page title
>
> Hi Joris,
>
> I think you found a bug.
> I've just looked into the code:
>
> // SEOHelperComponent.java: L114-116
> Element title = response.createElement("title");
> title.setTextContent(StringEscapeUtils.escapeHtml(mergedTitle));
> response.addHeadElement(title, "hst.seo.document.title");
>
> Because it was setting text content of DOM element, it should have set a
> normal unescaped string.
> I'll fix this error.
>
> In the meantime, you can override SEOHelperComponent#contributePageTitle().
> Or, I will fix this problem and release it asap, so you can wait for an
> update.
>
> Regards,
>
> Woonsan
>
> On 8/14/12 4:48 AM, Joris Meijer wrote:
>
>> Hi list,
>>
>> I was wondering, is there a reason why the page title is "html" escaped in
>> the SeoHelperComponent ?
>> It returns a very ugly page title in case, for instance, an umlaut is used:
>>
>> <title>Re&amp;euml;en - Kinderboerderij het hertje</title>
>>
>> Can I safely change this, so I can have this page title?
>>
>> <title>Reëen - Kinderboerderij het hertje</title>
>>
>> thanks for any info.
>>
>> Joris
>>
>>
>>
>>
>>
>> --
>> View this message in context: http://hippo.2275632.n2.nabble.com/hst-seo-support-html-escaped-page-title-tp7579038.html
>> Sent from the Hippo CMS 7 mailing list archive at Nabble.com.
>> _______________________________________________
>> Hippo-cms7-user mailing list and forums
>> http://www.onehippo.org/cms7/support/forums.html
>>
>
>
> --
> [hidden email]</user/SendEmail.jtp?type=node&node=7579044&i=0>     www.onehippo.com
> Boston - 1 Broadway, Cambridge, MA 02142
> Amsterdam - Oosteinde 11, 1017 WT Amsterdam
> US +1 877 414 4776 (toll free)
> Europe +31(0)20 522 4466
> _______________________________________________
> Hippo-cms7-user mailing list and forums
> http://www.onehippo.org/cms7/support/forums.html
> ________________________________
> If you reply to this email, your message will be added to the discussion below:
>
> NAML<
http://hippo.2275632.n2.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
>
>
>
>
>
> This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is
> intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to
> read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message
> in error, please notify the sender immediately and delete all copies of this message.
>
>
>
>
> --
> View this message in context: http://hippo.2275632.n2.nabble.com/hst-seo-support-html-escaped-page-title-tp7579038p7579045.html
> Sent from the Hippo CMS 7 mailing list archive at Nabble.com.
> _______________________________________________
> Hippo-cms7-user mailing list and forums
> http://www.onehippo.org/cms7/support/forums.html
>


--
[hidden email]     www.onehippo.com
Boston - 1 Broadway, Cambridge, MA 02142
Amsterdam - Oosteinde 11, 1017 WT Amsterdam
US +1 877 414 4776 (toll free)
Europe +31(0)20 522 4466
_______________________________________________
Hippo-cms7-user mailing list and forums
http://www.onehippo.org/cms7/support/forums.html


If you reply to this email, your message will be added to the discussion below:

http://hippo.2275632.n2.nabble.com/hst-seo-support-html-escaped-page-title-tp7579038p7579046.html

To unsubscribe from hst-seo-support html escaped page title, click here.
NAML